Rollup of 7 pull requests #148650

GuillaumeGomez · 2025-11-07T13:53:18Z

Successful merges:

Stabilize s390x vector target feature and is_s390x_feature_detected! macro #145656 (Stabilize s390x vector target feature and is_s390x_feature_detected! macro)
Modify contributor email entries in .mailmap #148204 (Modify contributor email entries in .mailmap)
Fix suggestion for returning async closures #148556 (Fix suggestion for returning async closures)
[rustdoc] Replace print methods with functions to improve code readability #148585 ([rustdoc] Replace print methods with functions to improve code readability)
re-use self.get_all_attrs result for pass indirectly attribute #148600 (re-use self.get_all_attrs result for pass indirectly attribute)
Add note for identifier with attempted hygiene violation #148612 (Add note for identifier with attempted hygiene violation)
Switch hexagon targets to rust-lld #148613 (Switch hexagon targets to rust-lld)

r? @ghost
@rustbot modify labels: rollup

…ssues

lld is a great choice for a default linker.

Updated email addresses for several contributors in the mailmap.

… r=Amanieu Stabilize s390x `vector` target feature and `is_s390x_feature_detected!` macro closes rust-lang#145649 closes rust-lang#135413 cc: rust-lang#130869 reference PR: rust-lang/reference#1972 # Stabilization report ## Summary This PR stabilizes the following s390x target features: - `vector` - `vector-enhancements-1` - `vector-enhancements-2` - `vector-enhancements-3` - `vector-packed-decimal` - `vector-packed-decimal-enhancement` - `vector-packed-decimal-enhancement-2` - `vector-packed-decimal-enhancement-3` - `nnp-assist` - `miscellaneous-extensions-2` - `miscellaneous-extensions-3` - `miscellaneous-extensions-4` Additionally, it stabilizes the `std::arch::is_s390x_feature_detected!` macro itself and stably accepts the target features listed above. ## Tests & ABI details Only the `vector` target feature changes the ABI, much like e.g. `avx2` it will, depending on the ABI, pass vector types in vector registers. This behavior is tested extensively: - [tests/assembly-llvm/s390x-vector-abi.rs](https://github.com/rust-lang/rust/blob/22a86f8280becb12c34ee3efd952baf5cf086fa0/tests/assembly-llvm/s390x-vector-abi.rs) - [tests/codegen-llvm/s390x-simd.rs](https://github.com/rust-lang/rust/blob/22a86f8280becb12c34ee3efd952baf5cf086fa0/tests/assembly-llvm/s390x-vector-abi.rs) - [tests/ui/abi/simd-abi-checks-s390x.rs ](https://github.com/rust-lang/rust/blob/22a86f8280becb12c34ee3efd952baf5cf086fa0/tests/ui/abi/simd-abi-checks-s390x.rs ) The remaining features don't influence the ABI, they only influence instruction selection. In stdarch we test that the expected instructions are in fact generated when the target feature is enabled. ## Implementation history For `is_s390x_feature_detected!`: - rust-lang/stdarch#1699 - rust-lang#138275 - rust-lang/stdarch#1720 - rust-lang/stdarch#1832 For `vector` and friends - rust-lang#127506 - rust-lang#135630 - rust-lang#141250 ## Unresolved questions There is a fixme in [tests/ui/abi/simd-abi-checks-s390x.rs](https://github.com/rust-lang/rust/blob/22a86f8280becb12c34ee3efd952baf5cf086fa0/tests/ui/abi/simd-abi-checks-s390x.rs): ``` // FIXME: +soft-float itself doesn't set -vector //``@[z13_soft_float]`` compile-flags: --target s390x-unknown-linux-gnu -C target-cpu=z13 -C target-feature=-vector,+soft-float //``@[z13_soft_float]`` needs-llvm-components: systemz ``` I'm not sure whether that blocks stabilization? --- The implementation first extracts the listed target features into their own `s390x_target_feature_vector` rust feature, and then stabilizes that. best reviewed commit-by-commit r? ``@Amanieu`` cc ``@uweigand`` ``@taiki-e``

Modify contributor email entries in .mailmap This adds mailmap entries for duplicates I found in https://thanks.rust-lang.org/rust/all-time/ If I added an entry for you and it is not correct, then please let me know! See the comments at the start of https://github.com/rust-lang/thanks/blob/master/mailmap/src/lib.rs for understanding these entries. After this gets into the repo, the thanks page will be regenerated within a day, and your double entries will be merged. cc ``@aochagavia`` cc ``@fasterthanlime`` cc ``@jackh726`` cc ``@jakubadamw`` cc ``@yaahc`` cc ``@jackpot51`` cc ``@jonhoo`` cc ``@marcoieni`` cc ``@onur-ozkan`` cc ``@rylev`` cc ``@willcrichton`` cc ``@yoshuawuyts``

…-closure, r=JonathanBrouwer Fix suggestion for returning async closures Fixes rust-lang#148493

…, r=yotamofek [rustdoc] Replace `print` methods with functions to improve code readability We have a lot of `print` methods, making it quite tricky to know what the types we're manipulating are. We did something similar with `Clean` trait a few years ago (the first PR was rust-lang#99638, followed by a lot of them). Each commit replaces one type for easier review. r? ``@yotamofek``

…ttrs, r=JonathanBrouwer re-use `self.get_all_attrs` result for pass indirectly attribute Could be a fix for a potential performance regression reported here rust-lang#144529 (comment). Apparently the regression later disappeared. Nevertheless, this seems like a decent refactor. r? `@JonathanBrouwer` (vaguely attribute-related, maybe there are other optimizations to that PR that we're missing)

…-hygiene-diagnostic, r=JonathanBrouwer Add note for identifier with attempted hygiene violation Fixes rust-lang#148580 I changed the original test to make sure we are pointing to the right scope.

…nBrouwer,Noratrieb Switch hexagon targets to rust-lld lld is a great choice for a default linker.

GuillaumeGomez · 2025-11-07T13:53:27Z

@bors r+ p=5 rollup=never

bors · 2025-11-07T13:53:29Z

📌 Commit 07d76d4 has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2025-11-07T16:55:40Z

⌛ Testing commit 07d76d4 with merge b108965...

Rollup of 7 pull requests Successful merges: - #145656 (Stabilize s390x `vector` target feature and `is_s390x_feature_detected!` macro) - #148204 (Modify contributor email entries in .mailmap) - #148556 (Fix suggestion for returning async closures) - #148585 ([rustdoc] Replace `print` methods with functions to improve code readability) - #148600 (re-use `self.get_all_attrs` result for pass indirectly attribute) - #148612 (Add note for identifier with attempted hygiene violation) - #148613 (Switch hexagon targets to rust-lld) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-11-07T17:07:03Z

💔 Test failed - checks-actions

rust-log-analyzer · 2025-11-07T17:09:20Z

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

spellchecking files
building external tool typos from package [email protected]
finished building tool typos
npm WARN deprecated [email protected]: < 24.10.2 is no longer supported
npm ERR! code 127
npm ERR! git dep preparation failed
npm ERR! command /node/bin/node /node/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/home/user/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm WARN deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm ERR! npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated [email protected]: This functionality has been moved to @npmcli/fs
npm ERR! npm WARN deprecated [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm ERR! npm WARN deprecated [email protected]: This package is no longer supported. Please use @npmcli/package-json instead.
npm ERR! npm WARN deprecated [email protected]: This package is no longer supported.
npm ERR! npm ERR! code 127
npm ERR! npm ERR! path /home/user/.npm/_cacache/tmp/git-cloneXXXXXX0gne2H/node_modules/rollup
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c patch-package
npm ERR! npm ERR! sh: 1: patch-package: not found
npm ERR! 
npm ERR! npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T17_05_42_455Z-debug-0.log

npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T17_05_35_041Z-debug-0.log
npm install did not exit successfully
tidy [extra_checks]: IO error: npm install returned exit code exit status: 127
tidy [extra_checks]: FAIL
tidy: The following check failed: extra_checks
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1549:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1279:29

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Build completed unsuccessfully in 0:03:08
  local time: Fri Nov  7 17:06:07 UTC 2025
  network time: Fri, 07 Nov 2025 17:06:07 GMT
##[error]Process completed with exit code 1.

GuillaumeGomez · 2025-11-07T17:16:27Z

@bors retry

bors · 2025-11-07T17:19:21Z

⌛ Testing commit 07d76d4 with merge d340e8c...

Rollup of 7 pull requests Successful merges: - #145656 (Stabilize s390x `vector` target feature and `is_s390x_feature_detected!` macro) - #148204 (Modify contributor email entries in .mailmap) - #148556 (Fix suggestion for returning async closures) - #148585 ([rustdoc] Replace `print` methods with functions to improve code readability) - #148600 (re-use `self.get_all_attrs` result for pass indirectly attribute) - #148612 (Add note for identifier with attempted hygiene violation) - #148613 (Switch hexagon targets to rust-lld) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-11-07T17:28:08Z

💔 Test failed - checks-actions

rust-log-analyzer · 2025-11-07T17:54:03Z

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

spellchecking files
building external tool typos from package [email protected]
finished building tool typos
npm WARN deprecated [email protected]: < 24.10.2 is no longer supported
npm ERR! code 127
npm ERR! git dep preparation failed
npm ERR! command /node/bin/node /node/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/home/user/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm WARN deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm ERR! npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated [email protected]: This functionality has been moved to @npmcli/fs
npm ERR! npm WARN deprecated [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm ERR! npm WARN deprecated [email protected]: This package is no longer supported. Please use @npmcli/package-json instead.
npm ERR! npm WARN deprecated [email protected]: This package is no longer supported.
npm ERR! npm ERR! code 127
npm ERR! npm ERR! path /home/user/.npm/_cacache/tmp/git-cloneXXXXXXzwWVyM/node_modules/rollup
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c patch-package
npm ERR! npm ERR! sh: 1: patch-package: not found
npm ERR! 
npm ERR! npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T17_26_46_651Z-debug-0.log

npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T17_26_39_513Z-debug-0.log
npm install did not exit successfully
tidy [extra_checks]: IO error: npm install returned exit code exit status: 127
tidy [extra_checks]: FAIL
tidy: The following check failed: extra_checks
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1549:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1279:29

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Build completed unsuccessfully in 0:03:05
  local time: Fri Nov  7 17:27:08 UTC 2025
  network time: Fri, 07 Nov 2025 17:27:08 GMT
##[error]Process completed with exit code 1.

yotamofek · 2025-11-07T22:18:52Z

@bors retry

bors · 2025-11-08T01:05:35Z

⌛ Testing commit 07d76d4 with merge efc5d30...

Rollup of 7 pull requests Successful merges: - #145656 (Stabilize s390x `vector` target feature and `is_s390x_feature_detected!` macro) - #148204 (Modify contributor email entries in .mailmap) - #148556 (Fix suggestion for returning async closures) - #148585 ([rustdoc] Replace `print` methods with functions to improve code readability) - #148600 (re-use `self.get_all_attrs` result for pass indirectly attribute) - #148612 (Add note for identifier with attempted hygiene violation) - #148613 (Switch hexagon targets to rust-lld) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-11-08T03:32:02Z

💔 Test failed - checks-actions

GuillaumeGomez · 2025-11-08T10:41:05Z

Seems like a flaky failure again. Considering there are other rollups open, let's close this one.

folkertdev and others added 19 commits November 6, 2025 12:49

extract s390x vector and friends to their own rust feature

0645ac3

std_detect: remove unneeded stability lines from s390x features macro

d69442f

std_detect: give s390x features more accurate features / tracking i…

02e4db5

…ssues

stabilize stdarch_s390x_feature_detection

c59298d

stabilize s390x_target_feature_vector

7516645

re-use self.get_all_attrs result for pass indirectly attribute

1a9cc78

Add note for identifier with attempted hygiene violation

12cde30

Fix suggestion for returning async closures

c92ef47

Switch hexagon targets to rust-lld

5ed01e9

lld is a great choice for a default linker.

Modify contributor email entries in .mailmap

fc20a28

Updated email addresses for several contributors in the mailmap.

Switch clean print methods into a function

f2794ce

Replace Display::fmt with write_char

0f03429

Rollup merge of rust-lang#148556 - chenyukang:yukang-fix-148493-async…

298c104

…-closure, r=JonathanBrouwer Fix suggestion for returning async closures Fixes rust-lang#148493

Rollup merge of rust-lang#148612 - chenyukang:yukang-fix-148580-macro…

0ae62c9

…-hygiene-diagnostic, r=JonathanBrouwer Add note for identifier with attempted hygiene violation Fixes rust-lang#148580 I changed the original test to make sure we are pointing to the right scope.

Rollup merge of rust-lang#148613 - androm3da:bcain/hex_lld, r=Jonatha…

07d76d4

…nBrouwer,Noratrieb Switch hexagon targets to rust-lld lld is a great choice for a default linker.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 8, 2025

GuillaumeGomez closed this Nov 8, 2025

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 8, 2025

GuillaumeGomez deleted the rollup-p7esi5w branch November 8, 2025 10:41

Rollup of 7 pull requests #148650

Rollup of 7 pull requests #148650

Conversation

GuillaumeGomez commented Nov 7, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Nov 7, 2025

Uh oh!

bors commented Nov 7, 2025

Uh oh!

bors commented Nov 7, 2025

Uh oh!

bors commented Nov 7, 2025

Uh oh!

rust-log-analyzer commented Nov 7, 2025

Uh oh!

GuillaumeGomez commented Nov 7, 2025

Uh oh!

bors commented Nov 7, 2025

Uh oh!

bors commented Nov 7, 2025

Uh oh!

rust-log-analyzer commented Nov 7, 2025

Uh oh!

yotamofek commented Nov 7, 2025

Uh oh!

bors commented Nov 8, 2025

Uh oh!

bors commented Nov 8, 2025

Uh oh!

GuillaumeGomez commented Nov 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

GuillaumeGomez commented Nov 7, 2025 •

edited by rustbot

Loading